package_control_channel icon indicating copy to clipboard operation
package_control_channel copied to clipboard

Add NativeScript Core XML Syntax

Open CatchABus opened this issue 3 years ago • 3 comments
trafficstars

  • [x] I'm the package's author and/or maintainer.
  • [x] I have have read [the docs][1].
  • [x] I have tagged a release with a [semver][2] version number.
  • [x] My package repo has a description and a README describing what it's for and how to use it.
  • [x] My package doesn't add key bindings. **
  • [x] If my package is a syntax it doesn't also add a color scheme. ***

My package is NativeScript Core XML Syntax. There are no packages like it in Package Control.

This package adds syntax highlighting for NativeScript Core XML files.

Syntax is identical to the default one for XML with the addition of highlighting view model bindings. The highlight color is the one used for CDATA tags.

CatchABus avatar Jun 20 '22 21:06 CatchABus

@packagecontrol-bot

CatchABus avatar Jun 20 '22 22:06 CatchABus

@packagecontrol-bot

CatchABus avatar Jul 03 '22 18:07 CatchABus

@packagecontrol-bot

CatchABus avatar Jul 31 '22 23:07 CatchABus

@packagecontrol-bot

CatchABus avatar Nov 15 '22 22:11 CatchABus

Have you considered extending or including the default XML syntax instead of duplicating most of it?

Your main scope is text.xml, but since you're extending the basic syntax for that, you might want to have a more specific one like text.xml.nativescript. Everything that supports text.xml would also support your syntax, but yours can now be targeted specifically as well.

I'm a bit worried about this replacing the default XML syntax for many users, for files that are not necessarily NativeScript. May or may not be a problem, especially if this is truly an extension of the default and maybe only for specific file extensions.

braver avatar Nov 20 '22 20:11 braver

Please respond to the feedback to continue the review.

braver avatar Dec 05 '22 15:12 braver

Have you considered extending or including the default XML syntax instead of duplicating most of it?

Your main scope is text.xml, but since you're extending the basic syntax for that, you might want to have a more specific one like text.xml.nativescript. Everything that supports text.xml would also support your syntax, but yours can now be targeted specifically as well.

I'm a bit worried about this replacing the default XML syntax for many users, for files that are not necessarily NativeScript. May or may not be a problem, especially if this is truly an extension of the default and maybe only for specific file extensions.

NativeScript is an existing framework that makes use of XML files for UI rendering stuff. This is currently a really small plugin that adds support for highlighting double-curly brace expressions {{ }} so it's a very small addition for xml in common. I can understand if it's a problem for general use though.

I could find a solution when plugin contains more features that affect the general use of XML.

CatchABus avatar Dec 05 '22 15:12 CatchABus