JustEnoughResources icon indicating copy to clipboard operation
JustEnoughResources copied to clipboard

Published 20 hours ago • verified publisher icon way2muchnoise

NPE from FakeClientWorld

Open LuminescentMoon opened this issue 6 years ago • 1 comments

FakeClientWorld does not initialize World.mapStorage field, leading to unexpected NPEs when other mods try to use the result of World.getMapStorage.

One solution would be to initialize mapStorage before calling ForgeEventFactory.gatherCapabilities. Note that an access transformer is necessary as World.mapStorage is marked protected.

Related issues from StellarSky:

  • https://github.com/MinecraftModDevelopmentMods/StellarSky/issues/104
  • https://github.com/MinecraftModDevelopmentMods/StellarSky/issues/113
  • https://github.com/MinecraftModDevelopmentMods/StellarSky/issues/115

LuminescentMoon avatar Aug 15 '19 00:08 LuminescentMoon

Will have to rewrite profiling for newer versions, leaving this open as a reminder.

way2muchnoise avatar Aug 10 '20 06:08 way2muchnoise

Closing old version issues, profiling needs to be rewritten for 1.19+ anyways

way2muchnoise avatar Aug 08 '23 17:08 way2muchnoise