Feature request - track potion effects required for certain advancements.

[anoomolu]

Hiya, been using Better Advancements for years and it's been working great, thanks for making such a useful mod!

I was wondering if it'd be possible to add the tracking feature already in advancements like A Balanced Diet, to the A Furious Cocktail and How did we get here? advancements? I think it'd be useful to figure out what effects you already have thanks to beacons/potion effects/baubles and what you still need.

I get that the latter is hidden by default, but if players choose to unhide it via datapack, I imagine it'd be useful.

I'm on Fabric 1.20.1 fwiw

[way2muchnoise]

Can't the criteriaDetail config be of use here? You can choose from 4 different settings:

• off -> Vanilla default, you get no info at all
• default -> BetterAdvancements default, you see a list of what you have done already
• spoiler -> you get to see a list of things you haven't done yet
• all -> you see both completed and to complete items (combination of default and spoiler)

[anoomolu]

I've got criteriaDetail set to Spoiler, but there is no list of effects to "tick off" unlike the other tracked advancements.

With a permanent invis effect and the config set to above:

(the advancement is working fine, just shuffled around some names and icons)

[way2muchnoise]

It is possible that this advancement technically only has one criteria (i.e., having all potion effects applied). The list will only show up when you can get "parts" of an advancement. Like advancements to visit all biomes or craft all different potions.

From which data pack or mod is this specific advancement?

[anoomolu]

The advancement is a copy of the vanilla How did we get here? advancement, with a name change and some effects removed. Edited it myself for a custom pack.

nether/all_effects in the client.jar/vanilla datapack should have all the original criteria (the potion effects required are listed there)

[way2muchnoise]

Seems like there were some issues with showing advancement criteria, can you please test version 0.4.3.20 or later?

[anoomolu]

Thanks for getting back to me on this. The potion effect criteria still aren't showing up sadly. Below is 0.4.3.21 on Fabric 1.21.1:

The criteriaDetail option is set to All, and the player has the fire resistance effect for infinite duration, but neither fire resist nor the other required criteria for the all_effects advancement show up.