wavi icon indicating copy to clipboard operation
wavi copied to clipboard

请问我要如何联系你,我有一个新的问题要与你探讨。 How can I contact you? I have a new question to discuss with you.

Open Best-partner opened this issue 7 years ago • 0 comments
trafficstars

请问我要如何联系你,我有一个新的问题要与你探讨。 How can I contact you? I have a new question to discuss with you.

Best-partner avatar Apr 05 '18 15:04 Best-partner

I think the tool silently ignores a lot of things, all errors are trapped and... discarded :grimacing: That needs some... fixing.

Gadgetoid avatar Jan 26 '21 14:01 Gadgetoid

Kind-of related: having an assets.yml that contains only non existing files now explodes. Entirely not a valid thing to be doing, but I've seen it more than once now...

Daft-Freak avatar Jan 30 '21 22:01 Daft-Freak

I've managed to trap the no-valid-files case early and explode in a somewhat more helpful manner.

However this doesn't solve the mixed case- I think the warning output about missing files needs to be escalated into a RuntimeError:

https://github.com/32blit/32blit-tools/blob/3b0d9849b36974497cb9c1ce205f1edb05cffe10/src/ttblit/tool/packer.py#L46

Gadgetoid avatar Mar 18 '21 10:03 Gadgetoid

Right, disregard the above... I think I've got it bailing sensibly now.

Gadgetoid avatar Mar 18 '21 10:03 Gadgetoid

Woof, I guess we can close this now?

Gadgetoid avatar Oct 30 '24 19:10 Gadgetoid

Seems like it:

[build] FAILED: examples/mp3/assets.hpp examples/mp3/assets.cpp /home/daftfreak/repos/32blit/32blit-sdk/build.Pico2-32blit/examples/mp3/assets.hpp /home/daftfreak/repos/32blit/32blit-sdk/build.Pico2-32blit/examples/mp3/assets.cpp 
[build] cd /home/daftfreak/repos/32blit/32blit-sdk/build.Pico2-32blit/examples/mp3 && cd /home/daftfreak/repos/32blit/32blit-sdk/examples/mp3 && /home/daftfreak/.local/bin/32blit --debug pack --force --config /home/daftfreak/repos/32blit/32blit-sdk/examples/mp3/assets.yml --output /home/daftfreak/repos/32blit/32blit-sdk/build.Pico2-32blit/examples/mp3
[build] Traceback (most recent call last):
[build]   File "/home/daftfreak/.local/bin/32blit", line 8, in <module>
[build]     sys.exit(main())
[build]              ^^^^^^
[build]   File "/home/daftfreak/.local/pipx/venvs/32blit/lib/python3.12/site-packages/click/core.py", line 1157, in __call__
[build]     return self.main(*args, **kwargs)
[build]            ^^^^^^^^^^^^^^^^^^^^^^^^^^
[build]   File "/home/daftfreak/.local/pipx/venvs/32blit/lib/python3.12/site-packages/click/core.py", line 1078, in main
[build]     rv = self.invoke(ctx)
[build]          ^^^^^^^^^^^^^^^^
[build]   File "/home/daftfreak/.local/pipx/venvs/32blit/lib/python3.12/site-packages/click/core.py", line 1688, in invoke
[build]     return _process_result(sub_ctx.command.invoke(sub_ctx))
[build]                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[build]   File "/home/daftfreak/.local/pipx/venvs/32blit/lib/python3.12/site-packages/click/core.py", line 1434, in invoke
[build]     return ctx.invoke(self.callback, **ctx.params)
[build]            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[build]   File "/home/daftfreak/.local/pipx/venvs/32blit/lib/python3.12/site-packages/click/core.py", line 783, in invoke
[build]     return __callback(*args, **kwargs)
[build]            ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[build]   File "/home/daftfreak/repos/32blit/32blit-tools/src/ttblit/tool/packer.py", line 123, in pack_cli
[build]     Packer().run(config, output, files, force)
[build]   File "/home/daftfreak/repos/32blit/32blit-tools/src/ttblit/tool/packer.py", line 46, in run
[build]     raise RuntimeError(f'Input file(s) {self.working_path / file_glob} not found for output {output_file}.')
[build] RuntimeError: Input file(s) /home/daftfreak/repos/32blit/32blit-sdk/examples/mp3/blarg.bin not found for output /home/daftfreak/repos/32blit/32blit-sdk/examples/mp3/assets.cpp.

Daft-Freak avatar Oct 30 '24 19:10 Daft-Freak

🥳

Gadgetoid avatar Oct 30 '24 19:10 Gadgetoid