python-sdk icon indicating copy to clipboard operation
python-sdk copied to clipboard

Fix on_close propogation + bump websocket-client

Open wwwehr opened this issue 3 years ago • 2 comments

Satisfies https://github.com/watson-developer-cloud/python-sdk/issues/810

Also, the websocket client class sends messages to the on_close handler that do not match the signature that result in an error:

from callback <bound method SynthesizeListener.on_close of
 <ibm_watson.websocket.synthesize_listener.SynthesizeListener object at
 0x123456789>>: on_close() takes 2 positional arguments but 4 were given

This PR fixes this issue.

wwwehr avatar Apr 17 '22 19:04 wwwehr

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 17 '22 19:04 CLAassistant

@jeff-arn @kevinkowa @hsaylor

Hoping to get this reviewed and merged. I thought I followed the contributors notes - please advise if I need to do anything else!

wwwehr avatar Jun 24 '22 16:06 wwwehr