wasp icon indicating copy to clipboard operation
wasp copied to clipboard

Consider removing lodash as a core Wasp dependency

Open shayneczyzewski opened this issue 3 years ago • 1 comments

Filip noticed that we only use lodash in a single file to perform _.merge of configs.

$ pwd && rg "lodash"  
/home/filip/wasp/reviews/waspc
data/Generator/templates/server/src/config.js
2:import _ from 'lodash'

src/Wasp/Generator/WebAppGenerator.hs
87:            ("lodash", "^4.17.15"),
$

We might consider removing it. It's a big dependency anyway and we can easily implement this ourselves. It's also pretty popular and removing it would allow our users to decide on the version they want to use on their own.

shayneczyzewski avatar Jun 30 '22 14:06 shayneczyzewski

Sounds good to me, nice catch!

Martinsos avatar Jun 30 '22 21:06 Martinsos

Can I try on this issue?

codingmickey avatar Oct 04 '22 04:10 codingmickey

Can I try on this issue?

Sure feel free to go for it!

Martinsos avatar Oct 06 '22 11:10 Martinsos

before I tried it's done by someone, accept his pr 👍🏽

codingmickey avatar Oct 10 '22 06:10 codingmickey