Warp icon indicating copy to clipboard operation
Warp copied to clipboard

PS1 powerline character color issue

Open brandonmcconnell opened this issue 3 years ago • 10 comments

Describe the bug

Middle PS1 Powerline symbol displays in a different color. This doesn't happen in iTerm or Hyper.

To Reproduce

Activate a zsh theme that utilizes Powerline characters, then enable custom PS1 in Warp.

Expected behaviour

I would expect the powerline character to inherit its color from the area to its left. Examples can be seen here: https://gist.github.com/480/3b41f449686a089f34edb45d00672f28

Screenshots

Screen Shot of Warp terminal with mis-colored powerline character

Operating System

MacOS

OS Version

12.3

brandonmcconnell avatar Mar 31 '22 14:03 brandonmcconnell

I have the same issue for tmux bar with powerline symbols:

warp:

image

iterm2:

image

bergtholdt avatar Apr 11 '22 09:04 bergtholdt

+1

byaruhaf avatar Apr 15 '22 00:04 byaruhaf

This is related: GitHub issue for supporting glyphs and Nerd Fonts: https://github.com/warpdotdev/Warp/issues/587​

We also have a number of rendering improvements that can be made: List of GitHub issues for rendering bugs like blurry font, incorrect or dim colors, and jagged corners

warpdotdev-devx avatar Apr 15 '22 07:04 warpdotdev-devx

I would like to add similar issue screenshots - it is for starship prompt and custom prompt design (Fira code nerd font etc.)

1: right hand side prompt loads without colors, left side is broken (it was supposed to be two line prompt): prompt_broken_rhlissue_glyph_colors

2: same one after running LS command. Right side prompt shows some colors but still looks slightly off (edges are not proper) and left side still broken: glyph_issue_somecolors

3: This is how it looks on other terminals:

this_is_how_it_should_be

supetronix avatar Jul 28 '22 23:07 supetronix

Check out #936 @super.

You can also disable parts of your dotfiles just for Warp by using this conditional statement:

if [[ $TERM_PROGRAM != "WarpTerminal" ]]; then

WHAT YOU WANT TO DISABLE FOR WARP - BELOW

Whatever you want to disable

WHAT YOU WANT TO DISABLE FOR WARP - ABOVE

fi

We have a list of incompatible tools in our documentation: https://docs.warp.dev/help/known-issues#list-of-incompatible-tools

warpdotdev-devx avatar Aug 02 '22 19:08 warpdotdev-devx

I'm confused the solution is to disable our fonts 🤔

byaruhaf avatar Aug 02 '22 19:08 byaruhaf

Not fonts, but prompt at least the right side. It probably ends up in your Input Editor if I'm not mistaken?

elviskahoro avatar Aug 02 '22 19:08 elviskahoro

The issue for multiline prompts should be #1015.

See this comment: https://github.com/warpdotdev/Warp/issues/1015#issuecomment-1141464869

elviskahoro avatar Aug 02 '22 19:08 elviskahoro

@elviskahoro - it does gets added to input but "sometimes" only (i.e. at start). Right side prompts shows up when new window is opened - which was screenshot 1 - but running ls or any command then only shows right side prompt on previous results i.e. right side prompt stops appearing on actual prompt :).

It looks ugly and all but for now I am not disabling it (the whole glyph formatting), just waiting for a fix (it is an eye sore right now but not affecting my work). Thanks for sharing issue links, although you mentioned on last link that starship works fine but it is still not perfect (as you can see in my screenshot).

supetronix avatar Aug 02 '22 20:08 supetronix

Multi-line starship prompts do get squeezed down to single line. If you end up disabling it make sure to use the Warp conditional that way it stays enabled for your other terminals though.

elviskahoro avatar Aug 02 '22 20:08 elviskahoro

I have the same issue for tmux bar with powerline symbols:

warp:

image

iterm2:

image

same here

soulomoon avatar Aug 23 '22 15:08 soulomoon

hello, any update on this, I also have the same issue

AliQ80 avatar Sep 27 '22 12:09 AliQ80

@warpdotdev-dx Still experiencing this issue where the powerline characters are the wrong colors. Is there a fix or workaround for this?

brandonmcconnell avatar Oct 01 '22 02:10 brandonmcconnell

Team is looking into adding a toggle that will help with the color differences.

elviskahoro avatar Oct 01 '22 21:10 elviskahoro

There aren't any updates at this time.

warpdotdev-devx avatar Oct 11 '22 07:10 warpdotdev-devx

Same here Screenshot 2022-10-13 at 19 39 17

StefanoOrdine avatar Oct 13 '22 17:10 StefanoOrdine

Sharing this across various color related issues. The team fixed one of the core issues with colors and there's a new toggle under Settings > Appearance that let's you configure whether to enforce a minimum contrast (one of the issues). Please check if you're still having color issues again and test tweaking the toggle:

CleanShot 2022-11-10 at 15 17 22@2x

elviskahoro avatar Nov 10 '22 23:11 elviskahoro

@elviskahoro Thanks! Switching that option to "never" fixed my issue.

brandonmcconnell avatar Nov 14 '22 21:11 brandonmcconnell

@StefanoOrdine now that this is resolved, would you mind letting me know how you achieved the rounded edge on the left? 👀🙏🏼

Same here Screenshot 2022-10-13 at 19 39 17

brandonmcconnell avatar Feb 04 '24 15:02 brandonmcconnell