Warp icon indicating copy to clipboard operation
Warp copied to clipboard

Keybindings don't trigger on non-US input sources - international i18n ime international keyboards

Open chevsky opened this issue 4 years ago • 49 comments
trafficstars

Describe the bug

Seems like keybindings rely on current input source.
For example, `cmd+p` does nothing while Ukrainian input source selected, same for `ctrl+r`. Same for `cmd+,` on French input source, etc.

To Reproduce

Steps to reproduce:

  1. Select non-US input source, ideally Cyrillic (e.g. Ukrainian)
  2. Press cmd+p

Expected behaviour

Command Palette should open.

Screenshots

No response

Operating System

MacOS

OS Version

12.0.1

Additional context

No response

chevsky avatar Nov 01 '21 22:11 chevsky

Thanks for reporting! This issue is caused by us how we interpret key presses (see here for an explanation of these concepts). There are tradeoffs to all three methods and ideally we should provide a setting for user to choose which one to use.

kevinyang372 avatar Nov 03 '21 16:11 kevinyang372

From @sunyouman via #678

Describe the bug

I use Korean Language.
When keyboard setting is Korean, I does not work Shortcut.

To Reproduce

Steps to reproduce:

  1. Change keyboard language to Korean
  2. Cmd + E
  3. Not working

However, Default Shortcut is OK (like Cmd + W)

Expected behaviour

Shortcut is worked

Screenshots

No response

Operating System

MacOS

OS Version

11.6

Additional context

No response

elviskahoro avatar Jan 28 '22 05:01 elviskahoro

Any update on this issue? it didn't work after 2022.04.18 version.

yam-liu avatar May 24 '22 13:05 yam-liu

any news? same problem on Chinese. and now, i have to switch input to ABC, then can be open

l3ve avatar Jun 21 '22 05:06 l3ve

any news? same problem on Chinese. and now, i have to switch input to ABC, then can be open

You can use macism and skhd to solve this bug temporarily.

For me: (f18 is the switch of en/zh input method, macism can also do this)

# fix Warp Chinese input method hotkey window issue
alt - space : [[ "$(macism)" = 'com.apple.keylayout.ABC' ]] && (skhd -k 'f2') || (skhd -k 'f18' && skhd -k 'f2')

yam-liu avatar Jun 21 '22 16:06 yam-liu

Probable duplicates: #1423, #1302, #1413, #1309

tkafka avatar Jul 05 '22 21:07 tkafka

@tkafka thanks for the help! Will reach out and circle back when there are updates.

elviskahoro avatar Jul 07 '22 18:07 elviskahoro

any news? same problem on Chinese. and now, i have to switch input to ABC, then can be open

You can use macism and skhd to solve this bug temporarily.

For me: (f18 is the switch of en/zh input method, macism can also do this)

# fix Warp Chinese input method hotkey window issue
alt - space : [[ "$(macism)" = 'com.apple.keylayout.ABC' ]] && (skhd -k 'f2') || (skhd -k 'f18' && skhd -k 'f2')

你这个意思是先切换成苹果默认的输入法再去按hotkey吗...

supervate avatar Aug 11 '22 08:08 supervate

@suopovate 是的

yam-liu avatar Aug 11 '22 11:08 yam-liu

这个hotKey的体验太糟糕了,除了输入法会导致hotKey失效,即使输入法没问题,也会在更新系统或者某些情况下,失效。。。重新给 warp 授权也无用

supervate avatar Sep 01 '22 09:09 supervate

Using International US layout for portuguese does not work either.

andremacola avatar Nov 16 '22 02:11 andremacola

Thanks for reporting! This issue is caused by us how we interpret key presses (see here for an explanation of these concepts). There are tradeoffs to all three methods and ideally we should provide a setting for user to choose which one to use.

Really need the opportunity to choose. I can't use warp 100% because this issue. Shortcut is very important as a tool.

h3z avatar Nov 28 '22 23:11 h3z

Any updates on this issue? It is very annoying to switch to ABC every time to open hotkey window when working on multi-layout keyboard 🤯

anfomin avatar Nov 30 '22 19:11 anfomin

Any updates on this issue? This bug is the only reason why I can't switch to Warp. Could you at least give us an option to set multiple hotkeys for different layouts?

neoantox avatar Jan 30 '23 20:01 neoantox

Quick update, we're working on IME (input method editor, aka international keyboard ) support. I believe CJK support is up first, with others to follow in the future.

dannyneira avatar Feb 07 '23 21:02 dannyneira

For example, cmd+p does nothing while Ukrainian input source selected

Interestingly enough, this one works for me in the latest version. But when I set up a global shortcut for the hotkey window (Opt+Cmd+T), it does only work with the English input source being active.

Bringoff avatar Mar 01 '23 11:03 Bringoff

any news? same problem on Chinese. and now, i have to switch input to ABC, then can be open

You can use macism and skhd to solve this bug temporarily.

For me: (f18 is the switch of en/zh input method, macism can also do this)

# fix Warp Chinese input method hotkey window issue
alt - space : [[ "$(macism)" = 'com.apple.keylayout.ABC' ]] && (skhd -k 'f2') || (skhd -k 'f18' && skhd -k 'f2')

体验完美, 感谢分享

h3z avatar Mar 05 '23 14:03 h3z

Discord comment:

AZERTY keyboard layout also has issues with keyboard shortcuts

dannyneira avatar Jun 14 '23 19:06 dannyneira

Closing this one as the initial issue was fixed. Keybindings work well using different input sources. Version: v0.2023.06.27.19.34.stable_01

chevsky avatar Jul 03 '23 11:07 chevsky

not work version: v0.2023.06.27.19.34.stable_01

totally same https://github.com/warpdotdev/Warp/issues/2226#issuecomment-1326925705

q344144460 avatar Jul 03 '23 14:07 q344144460

+1

YanHuize @.***>于2023年7月3日 周一22:14写道:

not work version: v0.2023.06.27.19.34.stable_01

totally same #2226 (comment) https://github.com/warpdotdev/Warp/issues/2226#issuecomment-1326925705

— Reply to this email directly, view it on GitHub https://github.com/warpdotdev/Warp/issues/341#issuecomment-1618398332, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAICAI2HNSWL7LYEUP2AMJTXOLHVRANCNFSM5HFCH7PA . You are receiving this because you commented.Message ID: @.***>

yam-liu avatar Jul 03 '23 14:07 yam-liu

+1

supervate avatar Jul 03 '23 14:07 supervate

Still not working in v0.2023.06.27.19.34 stable_01

not work version: v0.2023.06.27.19.34.stable_01

totally same #2226 (comment)

Fenhy avatar Jul 04 '23 07:07 Fenhy

Reopening as users still appear to have this issue.

As a possible workaround, try and switch the input to ABC ( US ) keyboard or a more involved workaround is to rebind the keyboard shortcuts while you're input is international and try again.

Longer term we're aware of the issue and it's on the backlog of things we can improve in the future so we appreciate your patience with this issue and it's complicated to fix.

dannyneira avatar Jul 05 '23 18:07 dannyneira

+1

version: v0.2023.09.06.18.09.stable_00 OS: Ventura 13.4 I am using a Belgian keyboard layout and it doesn't work. I have also tried with the French layout, still the same problem.

adildg avatar Sep 14 '23 09:09 adildg

离谱,两年多了,还没修复。。如果这是个很复杂的问题,那 iterm是如何解决的呢?

97Yates05 avatar Nov 28 '23 03:11 97Yates05

This is ridiculous, it's been over two years and it still hasn't been fixed... If this is a really complicated issue, then how did iterm2 solve it?

97Yates05 avatar Nov 28 '23 03:11 97Yates05

This is ridiculous, it's been over two years and it still hasn't been fixed... If this is a really complicated issue, then how did iterm2 solve it?

+1

yangchuansheng avatar Dec 29 '23 01:12 yangchuansheng

@dannyneira If this app is intended only for native English speakers, please indicate this prominently. Leaving an issue unfixed for three years can appear incompetent, especially since this problem does not exist in similar products.No offense intended, just stating the facts.

97Yates05 avatar Mar 04 '24 09:03 97Yates05

Same issue as already reported above, key cominatiosn do not work when using SWEDISH keyboard. On Ubuntu 23.10

yooakim avatar Mar 07 '24 12:03 yooakim