DumpTS icon indicating copy to clipboard operation
DumpTS copied to clipboard

CRC check of TLV/MMT stream

Open MMT-TLVassociation opened this issue 3 years ago • 4 comments

https://github.com/MMT-TLVassociation/DumpTS/commit/c884656196b29790064bb09ad455a6f7470431a8 (In crc.cpp, const uint8_t* is changed to uint8_t* . )

I added code to check CRC in DumpTS.

example: DumpTS file.mmts --CID=1 --pid=0xF300 --output=e00301.hevc

If there are any CRC error in TLV/MMT stream, CRC false message is output. I'll pull request if your are OK.

MMT-TLVassociation avatar Jun 16 '22 01:06 MMT-TLVassociation

Hi, thanks for your contribution, it is ok for me, please go ahead.

wangf1978 avatar Jun 16 '22 01:06 wangf1978

Thank you.

MMT-TLVassociation avatar Jun 16 '22 02:06 MMT-TLVassociation

Your codebase seems not to be a fork of the original source depot, I merged your changes manually, and I found some typos, and I changed it, the main change is if (peek_msg_id == 0x8000 || 0x8002 || 0x8003 || 0x8004)// Packet_id, which includes CRC32 Changed it to if (peek_msg_id == 0x8000 || peek_msg_id == 0x8002 || peek_msg_id == 0x8003 || peek_msg_id == 0x8004)// Packet_id, which includes CRC32

Please see commit

wangf1978 avatar Jun 17 '22 10:06 wangf1978

Yes, you are correct. Thank you for manually merging the changes.

MMT-TLVassociation avatar Jun 18 '22 00:06 MMT-TLVassociation