Force.com-Toolkit-for-NET icon indicating copy to clipboard operation
Force.com-Toolkit-for-NET copied to clipboard

Published 20 hours ago • verified publisher icon wadewegner

XmlSerializer Memory Leak Fix

Open nrubino opened this issue 8 years ago • 7 comments
trafficstars

…he XmlSerializer causes a serious memory leak if you do not use the two contructors mentioned here.

https://support.microsoft.com/en-us/help/886385/memory-usage-is-high-when-you-create-several-xmlserializer-objects-in-asp-net

From my testing this change also bumps performance atleast 2 fold with repetitive bulk saves

nrubino avatar May 23 '17 09:05 nrubino

Thanks for the contribution! Before we can merge this, we need @nrubino to sign the Salesforce Contributor License Agreement.

salesforce-cla[bot] avatar May 23 '17 09:05 salesforce-cla[bot]

Great job! This took my 100k bulk upload from 20 mins down to just under 3 mins. Memory usage went from 6GB down to normal 1GB. Amazing! Well done.

mjames15 avatar Oct 14 '17 22:10 mjames15

Are we going to be able to get this merged? This PR has been out there for a bit.

Thanks!

wh1337 avatar Jul 24 '19 20:07 wh1337

Are we going to be able to get this merged? This PR has been out there for a bit.

Thanks!

Do I need to do something?

nrubino avatar Jul 25 '19 19:07 nrubino

@nrubino seems you need to re-merge master into your topic branch, resolve any conflicts and push back up.

marknadig avatar Sep 12 '19 16:09 marknadig

Looks like some stuff still might need to be done before this can be pulled in.

bafadam avatar Aug 25 '20 20:08 bafadam

This was a huge help, thank you!

CodeOfDavid avatar Dec 14 '21 23:12 CodeOfDavid