woff icon indicating copy to clipboard operation
woff copied to clipboard

Wide review and Implementation status, Candidate Changes

Open svgeesus opened this issue 4 years ago • 13 comments

Four of the six WOFF 2.0 candidate changes are typos, or obvious for-completeness things (Uint32). Two should be tested.

  • [x] Candidate Correction 1: for a typo no tests needed
  • [ ] Candidate Correction 2: preserve optional symple glyph overlap flag
  • [x] Candidate Correction 3: definition of the UInt32 type was omitted no tests needed
  • [ ] Candidate Correction 4: polarity of on-curve flag bit
  • [x] Candidate Correction 5: typo in list numbering no tests needed
  • [x] Candidate Correction 6: update IETF links no tests needed

svgeesus avatar Aug 03 '21 17:08 svgeesus

Ping to wonder about testing for CC2 and CC4.

The next stage will be to fold in the CC which are merely editorial, and to make CC2 and CC4 Proposed Corrections. This will trigger an AC Review. So we need to have tests for this. or otherwise to show that existing software handles these correctly.

svgeesus avatar Jan 17 '22 18:01 svgeesus

This change has been tested, and found to be 100% backward compatible - legacy WOFF2 decoders do not care about reserved bit values, and do not expect or read an additional bit array at the end of the glyph table. Thus, legacy decoders continue to function as always, and updated decoders now preserve this optional bit.

Do such updated decoders exist?

svgeesus avatar Jan 17 '22 18:01 svgeesus

@garretrieger @vlevantovsky could we add this to the agenda today?

svgeesus avatar Jan 18 '22 13:01 svgeesus

Resolution: the four editorial changes are agreed as editorial Resolution: publish an updated WOFF2 Recommendation with two proposed corrections

https://www.w3.org/2022/01/18-webfonts-minutes.html#t01 https://www.w3.org/2022/01/18-webfonts-irc#T17-11-40

svgeesus avatar Jan 18 '22 17:01 svgeesus

Guide has now been updated on how to do this.

svgeesus avatar Mar 01 '22 19:03 svgeesus

Updated WOFF2 Recommendation with four editorial changes folded in and two Proposed Corrections, should be published Thursday 10 March 2022.

This will trigger a 60-day exclusion period, solely for the Proposed Corrections.

svgeesus avatar Mar 08 '22 16:03 svgeesus

On 10 March 2022 the WOFF2 specification was republished with two Proposed Corrections. These will become normative after a 60-day period of review. The previous four other Candidate Corrections were deemed editorial and have already been merged.

svgeesus avatar Mar 10 '22 12:03 svgeesus

Here are the questions we need to answer for the next stage (Request Director's Approval to incorporate Proposed Amendments into a Recommendation):

Document title, URLs, estimated publication date

Abstract

Status

Link to group's decision to request the update

[TODO: eg minutes, CfC in GitHub, email]

Link to Last Call for Review of Proposed Amendments

[TODO: eg minutes, CfC in GitHub, email]

Wide Review of Proposed Amendments

[TODO: list of issues? email thread? horizontal review?]

Issues addressed

[TODO: you may scope this to issues related to the proposed amendments]

Link to internal AC Review results

[TODO: include link to WBS, and any link to internal follow-up]

Formal Objections

[TODO: link to those if any. All Formal Objects must have a public record]

Implementation

[TODO: show adequate implementation experience of the proposed amendments]

Patent disclosures


For issues here is the curve flag one where we did the same as the MTX Express submission: and the overlap flag one was actually raised on the google implementation not on our spec, then Vlad added it to our agenda

For testing I see an action to create a test

For implementation experience, Dave Crossland mentioned handling this in fonttools and Garret alerted us that overlapSimpleBitmap was supported in the WOFF2 encoder/decoder and mentioned potential support in fonttools.

Anything else I am missing?

svgeesus avatar May 12 '22 19:05 svgeesus

Oh and once we have all the info required then we need a minuted decision to request the update

svgeesus avatar May 12 '22 19:05 svgeesus

Here is the last call announcement (W3C Member only link)

svgeesus avatar May 12 '22 19:05 svgeesus

The C++ WOFF2 does this and will be in Chrome m102. Tests are not yet in in the WOFF2 tests repo but the plan is to export them We are not sure regarding fonttools.

svgeesus avatar May 17 '22 16:05 svgeesus

The two overlapBitmap tests are not showing up in the WPT results so I guess the test suite needs to be rebuilt and the two new tests submitted to WPT as a PR.

svgeesus avatar Jul 29 '24 13:07 svgeesus

The two overlapBitmap tests are not showing up in the WPT results

Um, nevermind. Those are Decoder tests, not UserAgent tests. So of course they don't show up!

svgeesus avatar Jul 30 '24 11:07 svgeesus

Last Call resulted in 10 support incorporating the proposed corrections

svgeesus avatar Jul 30 '24 12:07 svgeesus

Implementation Report for the two WOFF2 Proposed Corrections.

svgeesus avatar Jul 31 '24 17:07 svgeesus

Dropping Agenda+ as we have an existing resolution

svgeesus avatar Jul 31 '24 18:07 svgeesus

Transition to updated Recommendation approved

svgeesus avatar Aug 05 '24 18:08 svgeesus