vc-data-model icon indicating copy to clipboard operation
vc-data-model copied to clipboard

Should we use `Ed25519Signature2020` in the Examples?

Open iherman opened this issue 1 year ago • 3 comments

In the examples with tabs (e.g., example 5) the proof is still of an old style: the proof type is identified through a @type property, referring to Ed25519Signature2020.

Shouldn't we change that to the usage of the cryptosuite property, referring to, e.g., eddsa-rdfc-2022?

I presume these tabs are generated by a script, so no use for a PR simply changing the examples...

iherman avatar Mar 10 '24 15:03 iherman

The issue was discussed in a meeting on 2024-03-27

  • no resolutions were taken
View the transcript

3.1. Should we use Ed25519Signature2020 in the Examples? (issue vc-data-model#1457)

See github issue vc-data-model#1457.

Manu Sporny: we should update to the more modern signature suites.
… at least ECDSA.
… and a selective disclosure example.

Ivan Herman: +1 to manu on this.

iherman avatar Mar 27 '24 16:03 iherman

The issue was discussed in a meeting on 2024-04-10

  • no resolutions were taken
View the transcript

2.4. Should we use Ed25519Signature2020 in the Examples? (issue vc-data-model#1457)

See github issue vc-data-model#1457.

Brent Zundel: we discussed this one a few weeks ago.

Manu Sporny: David Lehn is working on it, just has a long backlog, he'll get to it.
… suggestion was - we update ReSpec VC, not only show data integrity securing mechanisms, but some of the VC-JOSE/COSE mechanisms.

iherman avatar Apr 10 '24 16:04 iherman

The issue was discussed in a meeting on 2024-05-01

  • no resolutions were taken
View the transcript

3.1. Should we use Ed25519Signature2020 in the Examples? (issue vc-data-model#1457)

See github issue vc-data-model#1457.

Brent Zundel: David Lehn, can you talk to us about this issue?
… There are some cryptosuites that are being referred to specifically -- which should be updated.

David Lehn: This is related to the respec vc plugin, I haven't had time to work on it -- and I know Benjamin was making some changes to it and we had movement on it.
… There were some general ideas where we wanted to improve the generation of the output and improve auto-generation.
… I just need to re-prioritize things and get it done quickly, it's not a lot of work, I just need to spend some time on it.

Brent Zundel: Would it be possible by next week for you to let us know when you can get it done?

David Lehn: Yes, excellent.
… I'll probably just be doing it by then.

Brent Zundel: Ok, thank you for that feedback.

iherman avatar May 01 '24 16:05 iherman

In commit 0e6d623d15fb6a3ffadf1249580b5ba55d7894e4, the examples were updated to use respec-vc v3.0.0, which uses the newer Data Integrity cryptosuites.

This issue has been addressed, closing.

msporny avatar May 27 '24 19:05 msporny