tr-design icon indicating copy to clipboard operation
tr-design copied to clipboard

Links in insertions/deletions in Amendment boxes are handled correctly

Open rtoy opened this issue 4 years ago • 3 comments
trafficstars

In Amendment boxes, per https://fantasai.inkedblade.net/style/design/w3c-restyle/2020/readme#amendment, inserted text is green, and deleted text is struck thru and colored red.

However, if the inserted or deleted portion contains a link, the link is not styled as the surrounding text. Deleted links aren't struck thru red text, and inserted links aren't green. This makes for really confusing text when the diff is shown. For example, see https://pr-preview.s3.amazonaws.com/rtoy/web-audio-api/pull/2363.html#c2361-1 in step 3 and 3.2.

The "Detach" links show up twice because the target of the link changed. If they were styled as insertions/deletions, it would be easy to see that they're different instead of looking like duplicated text.

rtoy avatar Jul 13 '21 16:07 rtoy

See also https://github.com/tabatkins/bikeshed/issues/2104

rtoy avatar Jul 13 '21 16:07 rtoy

@deniak Fixed this in the repo, can you upload to w3.org?

fantasai avatar Sep 17 '21 23:09 fantasai

Done! I'll see how to automatically deploy the changes once merged on the gh-pages branch

deniak avatar Sep 18 '21 03:09 deniak