json-ld-api icon indicating copy to clipboard operation
json-ld-api copied to clipboard

Default value of produceGeneralizedRdf should be false

Open kal opened this issue 5 years ago • 2 comments

The definition of the JsonLdOptions Type specifies that the default value for produceGeneralizedRdf is true. However, there are tests that fail if this is the case (e.g. the toRdf test case e068 has an expected output that excludes the statement with a blank node property), and I note that the test manifests explicitly set the option to true when it is required for the test. That, plus the fact that this option is deprecated leads me to suspect that the definition of the options type is perhaps incorrect and that the default value for this property should be false.

kal avatar Jul 05 '20 20:07 kal

Yes, the default should be false, which is consistent with the warning that it may go away in the future.

gkellogg avatar Jul 05 '20 22:07 gkellogg

Summary:

The default value of the produceGeneralizedRdf option should be false, not true.

gkellogg avatar Oct 16 '22 21:10 gkellogg