aria-practices icon indicating copy to clipboard operation
aria-practices copied to clipboard

All Pages: Use multiple kbd elements for commands with multiple keys

Open mcking65 opened this issue 1 year ago • 1 comments

Replaces #1611.

Currently, keyboard commands that require pressing multiple keys are written as <kbd>key1 + key2</kbd>. This changes the syntax to <kbd>key1</kbd> + <kbd>key2</kbd>.

To change kbd elements that contained two keys separated by '+', searched for:

<kbd>(\w+)\s*\+\s*(\w+(?:\s+\w+)*)</kbd>

To change kbd elements that contained three keys separated by '+', searched for:

<kbd>(\w+)\s*\+\s*(\w+(?:\s+\w+)*)\s*\+\s*(\w+(?:\s+\w+)*)</kbd>

WAI Preview Link (Last built on Sun, 11 Aug 2024 20:42:11 GMT).

mcking65 avatar Aug 11 '24 20:08 mcking65

The ARIA Authoring Practices (APG) Task Force just discussed Fix for kbd elements.

The full IRC log of that discussion <jugglinmike> Topic: Fix for kbd elements
<jugglinmike> github: https://github.com/w3c/aria-practices/pull/3093
<jugglinmike> Matt_King: This is another one of those old patches that needed to be refactored and redone
<jugglinmike> Matt_King: The changes are simple; just need checking to make sure the search/replace didn't produce any unexpected and undesirable results.
<jugglinmike> Matt_King: This patch transforms 2- and 3-chord key commands according to how the "kbd" element is intended to be used
<jugglinmike> Adam_Page_: I can review that
<jugglinmike> arigilmore: I can review, as well
<jugglinmike> Matt_King: Great; I'll add you both
<jugglinmike> Matt_King: I'm not going to add a review checklist like we normally do because this one is so simple

css-meeting-bot avatar Aug 20 '24 18:08 css-meeting-bot