vyper icon indicating copy to clipboard operation
vyper copied to clipboard

refactor[tool]: reduce docker image size

Open sambacha opened this issue 3 years ago • 4 comments

ignore explicit

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

sambacha avatar Oct 11 '22 08:10 sambacha

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.97%. Comparing base (d29b521) to head (185dca3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3120   +/-   ##
=======================================
  Coverage   92.97%   92.97%           
=======================================
  Files         131      131           
  Lines       19067    19067           
  Branches     3319     3319           
=======================================
  Hits        17728    17728           
  Misses        902      902           
  Partials      437      437           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Oct 11 '22 09:10 codecov-commenter

this is a dup of #3111

charles-cooper avatar Oct 11 '22 20:10 charles-cooper

this is a dup of #3111

I'll say the same thing I said there, hopefully @sambacha confirms or makes an update: I see a few vyper-related files that I would expect to be in the build for it to function properly. That's why it needs some QA to see if it still functions correctly with the slimmed down fileset

specifically:

  1. vyper --version
  2. vyper SomeFile.vy (ensure it has the version pragma in it)
  3. Not sure what other things to check

fubuloubu avatar Oct 14 '22 13:10 fubuloubu

Let me update this later today for ya

sambacha avatar Apr 09 '23 22:04 sambacha