vyos-1x
vyos-1x copied to clipboard
T7388: IPv6 neighbor discovery not supported by every interface type
Change summary
The commit b124f0b ("interface: T4627: support IPv6 Interface Identifier (token) for SLAAC") revealed an incorrect assumption in VyOS: that all nterface types in use inherently support SLAAC and IPv6 Neighbor Discovery (ND).
However, this assumption does not hold true for WireGuard, Tunnel, and VTI interfaces. Therefore, the corresponding CLI option should not be available for these interface types. Additionally, SLAAC support should be removed for them in a future pull request.
To address this, remove the "ipv6 address autoconf" CLI tree from the following interface types using a migration script:
- WireGuard
- Tunnel
- VTI
Types of changes
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Code style update (formatting, renaming)
- [x] Refactoring (no functional changes)
- [ ] Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
- [ ] Other (please describe):
Related Task(s)
- https://vyos.dev/T7388
Related PR(s)
How to test / Smoketest result
Checklist:
- [x] I have read the CONTRIBUTING document
- [x] I have linked this PR to one or more Phabricator Task(s)
- [ ] I have run the components SMOKETESTS if applicable
- [x] My commit headlines contain a valid Task id
- [x] My change requires a change to the documentation
- [ ] I have updated the documentation accordingly
👍 No issues in PR Title / Commit Title
:white_check_mark: No issues found in unused-imports check.. Please refer the workflow run
CI integration ❌ failed!
Details
- CLI Smoketests (no interfaces) ❌ failed
- CLI Smoketests (interfaces only) ❌ failed
- Config tests 👍 passed
- RAID1 tests 👍 passed
- TPM tests 👍 passed
Doesn't IPv6 SLAAC works on p2p wireguard? When both ends are set with allowed ips 0.0.0.0/0 and ::/0
I'll test it when I have some free time
Doesn't IPv6 SLAAC works on p2p wireguard? When both ends are set with allowed ips 0.0.0.0/0 and ::/0
I'll test it when I have some free time
08:11:07.893544 IP6 fe80::fd78:d2ff:fe7b:e4a8 > ff02::2: ICMP6, router solicitation, length 8
08:11:07.893697 IP6 fe80::f91f:10ff:fe95:e1af > fe80::fd78:d2ff:fe7b:e4a8: ICMP6, router advertisement, length 56
I think the entire idea was missguided and misslead by the token implementation.