react-countdown-circle-timer icon indicating copy to clipboard operation
react-countdown-circle-timer copied to clipboard

Published 20 hours ago • verified publisher icon vydimitrov

Added new prop: isGrowing

Open bonqus opened this issue 3 years ago • 5 comments

Hi, thank you for creating this package. I had a use case where I needed the progress path to grow instead of shrink. So I thought you might appreciate the contribution of an isGrowing prop. In combination with rotation it solves my use case quite nicely.

I'm not sure how you handle versioning, so I have kept that out of the pr.

bonqus avatar Jun 23 '22 12:06 bonqus

Hey @bonqus, thanks for the PR :) It seems you were trying to achieve counting up? Is that correct?

vydimitrov avatar Jun 23 '22 13:06 vydimitrov

Hey @bonqus, thanks for the PR :) It seems you were trying to achieve counting up? Is that correct?

Not quite, it's still a countdown but the progress path just grows as the duration time reaches the end, instead of shrinking until it disappears. So for a 10-second timer, where 2 seconds have past it would look like this: prtsc

bonqus avatar Jun 23 '22 16:06 bonqus

But this would also be nice in the context of counting up to some set duration.

bonqus avatar Jun 27 '22 11:06 bonqus

That's cool :) Can you add please some tests for this new feature and I can merge it? You can do something similar to what I have for the tests in the web and mobile packages.

vydimitrov avatar Jul 06 '22 06:07 vydimitrov

That's cool :) Can you add please some tests for this new feature and I can merge it? You can do something similar to what I have for the tests in the web and mobile packages.

For sure, I will add it to the PR shortly :)

bonqus avatar Jul 11 '22 11:07 bonqus

That's cool :) Can you add please some tests for this new feature and I can merge it? You can do something similar to what I have for the tests in the web and mobile packages.

Hey bro, are u here?

Hedonismv avatar Feb 02 '23 18:02 Hedonismv

Hedonismv

Hi, Yeah, sorry I've been and am currently unable to prioritize writing the test.

bonqus avatar Feb 06 '23 14:02 bonqus

Great, lets push it :)

vydimitrov avatar Feb 06 '23 14:02 vydimitrov

This is great! Is it going to be merged?

rgavinc avatar Mar 12 '23 02:03 rgavinc

Hey @bonqus, here is a commit with the tests for the isGrowing prop. Please either add them to your PR or I will create a new PR for this feature. It seems this is feature that people need, so lets get it out!

vydimitrov avatar Mar 14 '23 07:03 vydimitrov

Hey @bonqus, here is a commit with the tests for the isGrowing prop. Please either add them to your PR or I will create a new PR for this feature. It seems this is feature that people need, so lets get it out!

I've added the tests, thank you for writing them.

bonqus avatar Mar 14 '23 10:03 bonqus

Great job! Thanks for the PR. I am now merging this it.

vydimitrov avatar Mar 15 '23 06:03 vydimitrov