Vyas Ramasubramani comments

Results 904 comments of


                                            Vyas Ramasubramani

Change the java API so a global default host allocator can be set.

@revans2 did this stall for any particular reason? Do we want to get this merged?

Change the java API so a global default host allocator can be set.

No problem. We can keep it open if you plan to come back to it, and you can retarget it then. I just wanted to clean it up if it...

Replace usages of `thrust::optional` with `std::optional`

Is there any reason that this didn't get merged? Should we get this updated and pushed through? Apologies if it simply fell through the cracks.

Replace usages of `thrust::optional` with `std::optional`

Got it, thanks! We'll revisit once #15327 is addressed then.

Replace usages of `thrust::optional` with `std::optional`

@miscco we've updated to 12.5 now, could you please rebase this PR onto the latest 24.08?

Replace usages of `thrust::optional` with `std::optional`

@miscco thanks! Nope, 24.10 is fine. I don't think this is urgent, but I was clearing out the backlog of open PRs and realized this one ought to be good...

Replace usages of `thrust::optional` with `std::optional`

OK, we have a few runs now here showing the same error. It's a single Python test that's failing in both wheel and conda CI in the same way, and...

Replace usages of `thrust::optional` with `std::optional`

No problem. I pushed on this a little since the original blocker was resolved and I was hoping to help you wrap it up, but since there is more actual...

Replace usages of `thrust::optional` with `std::optional`

Thanks both of you! I appreciate you taking point on getting this PR finished.

Replace usages of `thrust::optional` with `std::optional`

We finally sorted these issues out in #17793, specifically in https://github.com/rapidsai/cudf/pull/17793/commits/886c40e8671f68ee1895ba0f5b0301facfe3bd3b. The issue was in the SFINAE for the `IS_NULL` operator.