graph-representation-learning icon indicating copy to clipboard operation
graph-representation-learning copied to clipboard

Validation set generated but never used

Open saedr opened this issue 5 years ago • 1 comments

Dear Phi, In the following piece of code you generate the validation set but never return it, instead you use the test set instead of validation set and there is no actual test set to be used for testing purposes.

https://github.com/vuptran/graph-representation-learning/blob/48d59781b1b66a3a639153a4eac5269cfd9b723c/longae/utils_gcn.py#L153-L172

Am I missing something?

saedr avatar Dec 16 '19 03:12 saedr

@saedr sorry for the really late response. You are correct, I don't use the val set, but subsume it into the training set. The test set (see below) is used for testing purposes.

https://github.com/vuptran/graph-representation-learning/blob/master/longae/utils_gcn.py#L183

vuptran avatar Jan 22 '20 02:01 vuptran