vue-storefront-1 icon indicating copy to clipboard operation
vue-storefront-1 copied to clipboard

Per module configs instead of one big json

Open Zanuff opened this issue 6 years ago • 3 comments

What is the motivation for adding / enhancing this feature?

Currently the configs are kept in one big file, which may quickly increase in size, resulting in hard to read huge config chunk.

What are the acceptance criteria

Keep module config files per module for better separation. The architectural design is up to vue storefront team.

Can you complete this feature request by yourself?

  • [ ] YES
  • [x] NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • [x] This is a normal feature request. This should be available on https://test.storefrontcloud.io and then after tests this can be added to next Vue Storefront version. In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • [ ] (Pick this option only if you're sure) This is an important improvement request for current Release Candidate version on https://next.storefrontcloud.io and should be placed in next RC version. In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • [ ] (Pick this option only if you're sure) This is a critical improvement request for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version. In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Zanuff avatar May 27 '19 10:05 Zanuff

Thanks! This sounds good to me, however it makes the docs/initial config a little bit less straightforward. I belive we should discuss it or implement at first stage as an optional feature (so we don’t scatter the main config but rather extend the module API to let the developers to provide their own config providers)

pkarw avatar May 27 '19 19:05 pkarw

Related to vuestorefront/vue-storefront#2760

pkarw avatar May 27 '19 19:05 pkarw

This is actually idea we talked about with @patzick.i believe it is something we should think about in vs 2.0. It was proven to work well with Vue itself

filrak avatar Jun 17 '19 16:06 filrak