vue-curated icon indicating copy to clipboard operation
vue-curated copied to clipboard

What kind of packages are accepted?

Open egoist opened this issue 8 years ago • 10 comments
trafficstars

I mean some requirements like minimal stars, project activity, code quality, etc...

egoist avatar Jul 14 '17 11:07 egoist

I can suggest something like at least 2 approves after some basic tests by someone from the team. I have a lot of free time for that.

nickmessing avatar Jul 14 '17 12:07 nickmessing

I think we should close prs until we find out some reasoning when accepting packages or we'll end up doing the same mistakes we did with vue-awesome

posva avatar Jul 14 '17 15:07 posva

Yes, we should stop merging PRs for now - and I may need to revert a few ones that have already been merged, I've just been to busy to properly review them. The whole purpose of this project is curation so a formal requirement / evaluation process is needed.

yyx990803 avatar Jul 14 '17 15:07 yyx990803

Hi guys, any progress on this?

Justineo avatar Sep 12 '17 04:09 Justineo

My thoughts so far:

Minimal Requirements

  • Find and explain a common use case (shouldn't be too 'niche')
  • Have a demo repository to showcase it using this package only (focused demo)
  • Have a good enough documentation
    • We should discuss what's a 'good enough' doc
    • At least in English
    • It should have an API reference if it makes sense
  • If an npm package, it should be correctly compiled for an easy usage with at least webpack (and optionally the browser)
  • Have active maintainers on the repository
  • Get a core Vue member/contributor to test the demo project and verify it's a good solution for the use case
  • Have reasonable test coverage
    • having 100% might be really tiresome, but having the tests for the core functionality and pain points is always good and should be required
    • have CI set up on the repository
  • If visual (for example components), it should be reasonably polished (nice visual quality) and have a screenshot in the readme

Other Potential Requirements

  • Get a core Vue member/contributor to review the code and suggest improvements

Akryum avatar Sep 29 '17 10:09 Akryum

@Akryum looks good to me! I'd say we should run the current list through this and see if there are any that needs to be improved/removed.

yyx990803 avatar Sep 29 '17 15:09 yyx990803

Maybe we should create issues in the corresponding repositories?

Akryum avatar Sep 29 '17 15:09 Akryum

https://github.com/vuejs/vue-curated/blob/master/CONTRIBUTING.md (PR Welcome!)

Akryum avatar Sep 29 '17 16:09 Akryum

Maybe vuetify can be added to this list. quasar and vue-metarial is existing, but vuetify is not?

guyulmaz avatar Nov 10 '17 05:11 guyulmaz

Maybe since curation is not happening, and the last merge was some timeago, maybe the Vue team should just close this Repo and remove the Vue Curated link fro the Vue docs and un-publish the site?

tmorehouse avatar May 14 '19 00:05 tmorehouse