vitepress
vitepress copied to clipboard
vuejs
docs: add Persian language
Description
This PR adds the Persian language locale to VItePress Doc
Linked Issues
fixes #4047
Additional Context
[!TIP] The author of this PR can publish a preview release by commenting
/publishbelow.
Please update lunaria.json too. And I need someone from the community to review the translations. I also need feedback on RTL UI. Let me know which things look weird and how they should look, I will adjust the styles.
@brc-dd maybe this can help you (or not ;) ): https://github.com/elk-zone/elk/blob/main/CONTRIBUTING.md#rtl-support
Please update lunaria.json too. And I need someone from the community to review the translations. I also need feedback on RTL UI. Let me know which things look weird and how they should look, I will adjust the styles.
@brc-dd Thanks, sure.
- Nav: spacings between items are not correct
- Hero: text-align should be right
- Sidebar: it's better to put the sidebar on the right side of the page
- Search input: spacings are not correct
- Search modal: spacings in the footer and inside the input (the space between the icon and the text)
- Change language select: when using RTL, the spacings of the Persian options are not correct:
@brc-dd Are there any updates on fixing RTL issues? Is there anything I can help with?
Ah, sorry, no. I'm bit busy recently with day job. Will try to look into by next week.
Ah, sorry, no. I'm bit busy recently with day job. Will try to look into by next week.
No problem. Let me know if there's anything I can help you with.
Sorry for the delay.
Can you check the preview again and list out the issues?
Also, the individual headings need anchors, so that switching locales can keep the position same. See https://github.com/vuejs/vitepress/blob/main/docs/ru/guide/asset-handling.md?plain=1 for example (notice things inside {...})
Sorry for the delay.
Can you check the preview again and list out the issues?
Also, the individual headings need anchors, so that switching locales can keep the position same. See https://github.com/vuejs/vitepress/blob/main/docs/ru/guide/asset-handling.md?plain=1 for example (notice things inside
{...})
Everything looks fine.
There's another thing that I suggest changing. If the text color has opacity in languages like Persian (where the characters are connected), the overlap of characters will be bolder. Can we remove the opacity and use solid text colors to avoid the bolder overlap of characters?
Updated the colors. Please add the headers thing I mentioned earlier and this will be good to merge I guess 👀
external link icons shouldn't be changed with transform: rotate(-90deg)?
This should be the result: