vitepress icon indicating copy to clipboard operation
vitepress copied to clipboard

feat(theme-default): add built-in global component Badge.

Open szsascha opened this issue 3 years ago • 4 comments
trafficstars

fixes open changes from #1134 since there is no progress anymore and some people really want this feature

fixes #1156

szsascha avatar Aug 25 '22 18:08 szsascha

looking forward...

yansongda avatar Sep 01 '22 06:09 yansongda

Any updates please?

yansongda avatar Sep 13 '22 02:09 yansongda

I'll look into this!

kiaking avatar Sep 14 '22 09:09 kiaking

@kiaking How is it going?

szsascha avatar Sep 16 '22 20:09 szsascha

@brc-dd I've updated the docs! Could you take a final look? If it looks OK, please merge it! 🙌

kiaking avatar Oct 31 '22 08:10 kiaking

fixes open changes from #1134 since there is no progress anymore and some people really want this feature

close #1134 close #1156

It's suprising that those changes could be merged. I thought this feature wouldn't be accepted due to the consideration here, so I stopped watching the #1134, I feel very sorry.

Anyway, thx for @szsascha @kiaking ! ♪(・ω・)ノ it's nice of you to take another PR and make it better.

richardo2016 avatar Nov 05 '22 18:11 richardo2016

@brc-dd I've updated the docs! Could you take a final look? If it looks OK, please merge it! 🙌

Doesnt look to be rendered in my test env

Goozoon avatar Nov 10 '22 14:11 Goozoon

@Goozoon Can you share a minimal reproducible example? It is working fine on our deployed docs. You might not have extended the default theme properly.

brc-dd avatar Nov 10 '22 14:11 brc-dd

Pure vanilla Yarn Init thingy and copy=paste from the docs to see the result. Nothing about "extended the default theme" in the docs.

@Goozoon Can you share a minimal reproducible example? It is working fine on our deployed docs. You might have not extended the default theme properly.

Goozoon avatar Nov 10 '22 14:11 Goozoon

@Goozoon It's working fine for me: https://stackblitz.com/edit/vite-wbmmgk?file=docs%2Findex.md If it's not for you, feel free to open a new issue with details. Also, can you check if you're on the latest VitePress version?

brc-dd avatar Nov 10 '22 15:11 brc-dd

let me check yours.. thank you

Goozoon avatar Nov 11 '22 12:11 Goozoon

my fault:

yarn docs:dev -> vitepress v1.0.0-draft.8

in dependencies:

"devDependencies": { "vitepress": "^1.0.0-alpha.28",

Goozoon avatar Nov 11 '22 12:11 Goozoon