eslint-plugin-vue icon indicating copy to clipboard operation
eslint-plugin-vue copied to clipboard

Add block-attributes-order rule

Open Kingwl opened this issue 3 years ago • 4 comments

Fixes #1970

Kingwl avatar Sep 16 '22 07:09 Kingwl

@Kingwl thanks for the PR!

is the default order going to be

<script setup lang="ts"></script>

OR

<script lang="ts" setup></script>

it's hard to tell from the PR markdown file alone.

PS: I think the former is better for consistency with official Vue documentation

mesqueeb avatar Sep 17 '22 04:09 mesqueeb

Added the default orders into markdown.

AFAIK, there's no official Vue recommended block attributes order.

@sodatea Any suggestions?

Kingwl avatar Sep 19 '22 03:09 Kingwl

@Kingwl https://vuejs.org/guide/typescript/composition-api.html

Official Vue docs use <script setup lang="ts">

So I think having the same default as that seems best : )

mesqueeb avatar Sep 19 '22 05:09 mesqueeb

Done.

And make style block has xxx yyy lang src order too (for the consistency).

Kingwl avatar Sep 19 '22 05:09 Kingwl

I've been very busy lately with non-volunteer work. I haven't been able to check the latest changes for this PR yet. Status is always as you can see in PR. Please refrain from comments asking about progress.

ota-meshi avatar Oct 19 '22 00:10 ota-meshi

@Kingwl friendly bump : )

mesqueeb avatar May 16 '23 08:05 mesqueeb

Hey there, would be great to have this rule 👍 Happy to help! I can also come up with a new pull request if that is preferred.

paescuj avatar Jul 01 '23 09:07 paescuj

From our side, a new PR replacing this one would be fine.

FloEdelmann avatar Jul 03 '23 12:07 FloEdelmann

I'll close this for now as it seems abandoned and there are already some merge conflicts. Feel free to open another PR :slightly_smiling_face:

@paescuj this is your chance! :wink:

FloEdelmann avatar Jul 27 '23 13:07 FloEdelmann