vue-final-modal icon indicating copy to clipboard operation
vue-final-modal copied to clipboard

Published 20 hours ago • verified publisher icon vue-final

Wrong typescript exports

Open vaiil opened this issue 3 years ago • 3 comments
trafficstars

Version

vue-final-modal: 3.4.4 vue: 3.2.33

OS

Linux

Reproduction Link

https://codesandbox.io/s/icy-pine-fm35pi?file=/src/App.vue

Steps to reproduce

Try to import:

import { VueFinalModal } from 'vue-final-modal';

What is Expected?

It should be imported without TS warnings.

What is actually happening?

TS shows error, that this module not found image

Default import doesn't work at all.

vaiil avatar May 18 '22 14:05 vaiil

I can confirm this bug. Try importing single items without braces.

Solution import VueFinalModal from 'vue-final-modal'

kevinrieger avatar May 23 '22 09:05 kevinrieger

I can confirm this bug exists

I can confirm this bug. Try importing single items without braces.

Solution import VueFinalModal from 'vue-final-modal'

I tried it, it doesn't work unfortunately, it shows the below warning and the modal doesn't work.

[Vue warn]: Invalid VNode type: undefined (undefined) 
  at <Ze modelValue=false onUpdate:modelValue=fn > 
  at <Modal> 
  at <App>

HabardiT avatar Jun 29 '22 11:06 HabardiT

Any updates on this? Seems weird that its flagged as an error when it really isn't

carlfranciscastillo avatar Jul 08 '22 05:07 carlfranciscastillo

@hunterliu1003 the PR that I created should fix this problem. It's possible that you could review it?

alexpvieira avatar Sep 30 '22 07:09 alexpvieira

Released in v3.4.6

hunterliu1003 avatar Oct 29 '22 15:10 hunterliu1003