Vanya Sergeev

Results 55 comments of Vanya Sergeev

@patel-jeel92 I can help with some of the formatting issues to get this PR to the finish line.

Currently briefsky can't distinguish Light Rain from Rain for PirateWeather: https://github.com/vsergeev/briefsky/blob/v1.4.0/src/providers/PirateWeatherProvider.ts#L5-L16 , because Light Rain isn't enumerated in the API for Icon: https://docs.pirateweather.net/en/latest/API/#icon . If it is a valid icon...

Sure, if it's an optional layout setting, I'd definitely consider adding it.

Not showing temperature units is consistent with the Dark Sky interface: https://web.archive.org/web/20220707133449/darksky.net/forecast/40.7127,-74.0059/us12/en , which briefsky is modeled after. However, I can see the argument for showing it in at most...

The hourly duplication also depends on weather providers. Some weather providers will give historical hourly data for the current day, while others will only give future hourly data. briefsky will...

Great idea -- ideally a library that can be pulled in at build time. A simple, small footprint one like [gettext.js](https://github.com/guillaumepotier/gettext.js/) might fit nicely.

Unfortunately, this is hard for me to help debug without access to a Rockchip platform. Can you read the initial state of the PWM -- `pwm.period_ns` and `pwm.duty_cycle_ns` -- before...

@Livius90 thanks for the PR. My only concerns are that we shouldn't add `*_INVALID` states to the end of the enums. What if we legitimately needed to add a new...

It's not practical to put the invalid state after a bunch of valid ones. That's not only confusing, but also breaks the enum for any future additions. I agree with...

> Do you mean the `*_INVALID` type should be the first like this? > > ```c > typedef enum pwm_polarity { > PWM_POLARITY_INVALID, > PWM_POLARITY_NORMAL, /* Normal polarity */ >...