node-soap
node-soap copied to clipboard
updated axios and axios-ntlm to latest
latest version of axios-ntlm fixes node v18 digital envelope error Error: error:0308010C:digital envelope routines::unsupported
updated axios to latest: 1.3.2 updated axios-ntlm to latest: 1.4.0 (uses axios 1.3.2)
also 2 tests where failing because of hardcoded response Content-Length
this request needs to be accepted to pass all tests: https://github.com/vpulim/node-soap/pull/1206
Would like to see this update as well!
Same here, we're upgrading to node 18 and now need to --force to do any npm install...
Looking forward to get this changes
Looking forward to see this update too!
@vision10 plz fix the build
@jsdevel I have included changes from https://github.com/vpulim/node-soap/pull/1206 build should be ok
@jsdevel are we happy to merge now?
is there no one able to merge here? axios is already at 1.4.0 since this pull request some of the other pull requests can be closed or just need a bit of attention
idk, this seems like a sleeping law in congress
Sorry to be that guy, but could this get merged and released? It's blocking us at the moment.
We might need to sign a petition for this PR to get merged 😆
Agreed it would be great to see this merged
Bump. Is anyone still maintaining this repo?
Bump, will this be merged someday ?
Bump. This is a critical update.
Any update on this one @vpulim
FYI. In order to continue to use this package we all need to now use --force or --legacy-peer-deps until this is merged. Or we will need to find an alternative. Can we maybe delegate somebody to maintain this library since there are many of us who would contribute to resolve things like this?
+1
+1
+1
sdfghujiopm
What-the... Bump.
Hi, why is axios a peer dependency any way? I can't see the reason. If we could move it as a normal dependency we wouldn't be here waiting for using axios 1.0 and this library together.
You can solve this issue without waiting for the PR to be merged, seems like this might be a dead project. In your package.json just add the following to overrides:
"dependencies": { ... }, "overrides": { "soap": { "axios": "^1.0.0" } }, "devDependencies": { ... },
+1
Same here! @vpulim Any chance to get this merged?
Any timeline for when this pr will be merged and released ? 🤔
Merge please this is ruining the package
We seriously need someone to accept these pull requests that are piling up, not just mine @vpulim please give someone access to manage this repository if you are too busy
axios version has known vulnerabilities https://security.snyk.io/vuln/SNYK-JS-AXIOS-6032459
@RJWerning can you confirm that the override works? I didn't want to risk it because it's a major version upgrade but now there's this new security vulnerability...