node-soap icon indicating copy to clipboard operation
node-soap copied to clipboard

Published 20 hours ago • verified publisher icon vpulim

Fix build in Node.js 18 by re-encrypting test key

Open e6c31d opened this issue 2 years ago • 6 comments

The encrypted private key test/certs/agent2-key-with-password.pem was encrypted with DES, which is unsupported in Node.js 18. I re-encrypted it with AES, and now the build works in Node.js 18.

e6c31d avatar Dec 11 '22 06:12 e6c31d

@jsdevel I don't know why the build fails in CI. It works fine locally. I think it's related to IPv6?

e6c31d avatar Dec 12 '22 21:12 e6c31d

I tried to fix the CI build by explicitly listening on 127.0.0.1 since the test is expecting that. I assume CI is defaulting to IPv6 so it was getting ::1 instead.

e6c31d avatar Dec 13 '22 06:12 e6c31d

@e6c31d still failing

jsdevel avatar Dec 15 '22 21:12 jsdevel

@jsdevel Can you re-run the build? I believe the build issue is fixed.

e6c31d avatar Mar 15 '23 07:03 e6c31d

Hi @jsdevel Seems the other PR (https://github.com/vpulim/node-soap/pull/1212) is blocked by this, we appreciate if you can review and approve this

RezaRahmati avatar Mar 20 '23 18:03 RezaRahmati

@jsdevel Sorry to ping you repeatedly, but can you please re-run the build and merge this PR?

e6c31d avatar May 08 '23 11:05 e6c31d