puppetboard
puppetboard copied to clipboard
Configurable Overview page
This should create a configurable frontpage, based on the work of @gdubicki
Based on PR #614
Codecov Report
Merging #639 (bc0ddf5) into master (8244e29) will decrease coverage by
2.14%. The diff coverage is68.23%.
@@ Coverage Diff @@
## master #639 +/- ##
==========================================
- Coverage 81.54% 79.40% -2.15%
==========================================
Files 12 12
Lines 878 908 +30
==========================================
+ Hits 716 721 +5
- Misses 162 187 +25
| Impacted Files | Coverage Δ | |
|---|---|---|
| puppetboard/app.py | 73.53% <64.00%> (-3.18%) |
:arrow_down: |
| puppetboard/default_settings.py | 100.00% <100.00%> (ø) |
|
| puppetboard/docker_settings.py | 100.00% <100.00%> (ø) |
|
| puppetboard/version.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 5ef6429...bc0ddf5. Read the comment docs.
Unfortunately, you seem to hit the same issue as I did when I worked on this, @sebastianrakel .
When using the code from your branch as of now, if you set NODES_STATUS_DETAIL_ENABLED = False and RESOURCES_STATS_ENABLED = False then you are not making the query to get the number of nodes with each status and it results if showing zeros everywhere:
I have to investigate this, it works a few days ago :D will have a look into it tomorrow
Please rebase and let us know if it works for you, @sebastianrakel . 🙂