Why is the module still depending on a deprecated module: puppetlabs/pe_gem

[squaricdot]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 5.3.4
• Ruby: ruby 2.4.3p205
• Distribution: centos-release-7-4.1708
• Module version: 6.4.2

How to reproduce (e.g Puppet code you use)

Installing the module

What are you seeing

└─┬ puppet-zabbix (v6.4.2) ├── UNMET DEPENDENCY puppetlabs-pe_gem (>= 0.2.0 < 2.0.0

What behaviour did you expect instead

No unmet dependencies on modules that are no longer needed.

Latest commit 6e09aea on Jan 28, 2016 @ puppetlabs/pe_gem

Output log

Any additional information you'd like to impart

[bastelfreak]

Hi @squaricdot, can you provide a PR to remove it + the related code?

[baurmatt]

This is, more or less, still needed:

class zabbix::params {
...
  # Gem provider may vary based on version/type of puppet install.
  # This can be a little complicated and may need revisited over time.
  if str2bool($facts['is_pe']) {
    if $facts['pe_version'] and versioncmp($facts['pe_version'], '3.7.0') >= 0 { # lint:ignore:only_variable_string
      $puppetgem = 'pe_puppetserver_gem'
    } else {
      $puppetgem = 'pe_gem'
    }
  } else {
    if $facts['puppetversion'] and versioncmp($facts['puppetversion'], '4.0.0') >= 0 {
      $puppetgem = 'puppet_gem'
    } else {
      $puppetgem = 'gem'
    }
  }
...

Not sure if this should be a hard dependency.