puppet-prometheus
puppet-prometheus copied to clipboard
voxpupuli
WIP: Fix for the #434 dependency cycle
Fixes #434
Note: this PR is still Work-In-Progress as I have not tested all edge cases but it does work. Perhaps you have the time to take a look on your side and maybe your will either immediately tell me that is totally wrong or the other way around. I will get back to this when I will have more time.
Could you see if https://github.com/voxpupuli/puppet-prometheus/issues/434#issuecomment-698615967 or similar helps?
Dear @gdubicki, thanks for the PR!
This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com. You can find my sourcecode at voxpupuli/vox-pupuli-tasks
![vox-pupuli-tasks[bot] avatar](https://avatars.githubusercontent.com/in/37588?v=4 "Published by a pub.dev verified publisher"){kind=small}
Can someone who knows beaker better than me please check why the CI test are failing? I tried rebasing against master in https://github.com/voxpupuli/puppet-prometheus/pull/534 but it did not help.
Since puppet 6 is not supported anymore I think this is obsolete. Please re-open the PR if I am wrong
