Add support for new feature: port ranges

[00ssh]

Pull Request (PR) description

Updated listen_port data type from Integer to Variant[String, Integer] in 'nginx::resource::server' and 'nginx::resource::streamhost' as newer versions of Nginx support port range at listen port. Please check the release notes from 26th of March:

• http://nginx.org/en/CHANGES
• https://www.nginx.com/blog/nginx-plus-r18-released#port-ranges

Changes with nginx 1.15.10                                       26 Mar 2019

    *) Change: when using a hostname in the "listen" directive nginx now
       creates listening sockets for all addresses the hostname resolves to
       (previously, only the first address was used).

    *) Feature: port ranges in the "listen" directive.
...

[puppet-community-rangefinder[bot]]

nginx::resource::server is a type

The enclosing module is declared in 9 of 575 indexed public Puppetfiles.

Breaking changes to this file WILL impact these modules (exact match):

• covata-safeshare
• akisakye-matomo
• dhollinger-devopsdays
• samuelson-custom_webapp
• jonhallettuob-existdb
• pgassmann-letsencrypt_nginx
• othalla-nextcloud
• geoffwilliams-r_profile

Breaking changes to this file MAY impact these modules (near match):

• 4n0m4l0u5-configure_nginx nginx::resource::streamhost is a type

---

The enclosing module is declared in 9 of 575 indexed public Puppetfiles.

that may have no external impact to Forge modules.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[00ssh]

Hi, Can someone point to me, please, what is wrong with my travis tests? The error seems to be: An error occurred while loading ./spec/acceptance/class_spec.rb. Failure/Error: install_module_dependencies_on(hosts) Beaker::Host::CommandFailure: Host 'debian9-64-1' exited with 1 running: puppet module install puppetlabs-concat -v 5.3.0 Last 10 lines of output were: Notice: Preparing to install into /etc/puppetlabs/code/environments/production/modules ... Notice: Downloading from https://forgeapi.puppet.com ... Error: Could not install module 'puppetlabs-concat' (???) No version of 'puppetlabs-concat' can satisfy all dependencies Use puppet module install --ignore-dependencies to install only this module

[00ssh]

It might have been a forge issue. Now all checks have passed. Can you please take a look at my changes and let me know if it can be merged?

[00ssh]

@ekohl @dhoppe can you please give me feedback on this change? we are eager to have this implemented. Thanks!

[dhoppe]

I wonder if we should check the version of Nginx somewhere before configuring port ranges. We already did that for some templates, based on the fact nginx_version.

[dhoppe]

@ekohl I would like to merge this pull request. Any objections?

[00ssh]

Hi guys! Are there any other pending issues with this pull request? We would like to start using it from Forge as soon as possible.

Thanks!

[00ssh]

@ekohl any updates on my pull request, please?

[vox-pupuli-tasks[bot]]

Dear @00ssh, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks