verl icon indicating copy to clipboard operation
verl copied to clipboard

[recipe] fix: Qwen3-vl npu patch

Open leisuzz opened this issue 1 week ago • 1 comments

What does this PR do?

  1. Qwen3-vl with FSDP will need transformers > 4.57.1. Otherwise, bug will occur in transformers.
  2. Add npu patch to Qwen3-vl to increase the performance

Checklist Before Starting

  • [x] Search for similar PRs. Paste at least one query link here: ...
  • [x] Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

[!IMPORTANT] Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

leisuzz avatar Nov 18 '25 11:11 leisuzz

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 18 '25 11:11 CLAassistant

I’m on board with the PR itself, but our NPU-patch has added more and more Transformers compatibility changes over time—leading to noticeable maintenance difficulties. It’s time to upgrade the Transformers version on the NPU and clean up parts of the NPU-patch code accordingly.

Transformers version in verl for Ascend NPU has updated to latest version (v4.57.1), including current e2e_ascend CI. Maybe we can clean some redundant patching now.

FightingZhen avatar Nov 19 '25 02:11 FightingZhen