verl icon indicating copy to clipboard operation
verl copied to clipboard

fix Ray runtime env no working dir issue

Open kunling-anyscale opened this issue 1 month ago • 2 comments

What does this PR do?

Respect Ray Job runtime_env in PPO runs by fixing get_ppo_ray_runtime_env():

  • Do not inject working_dir=None (omit key entirely if absent).
  • Pass through working_dir from RAY_JOB_CONFIG_JSON_ENV_VAR when provided.
  • Avoid overriding env vars already present in os.environ.

This prevents VERL from clobbering a valid job working_dir and stabilizes env-var merge semantics when users submit via Ray Jobs.

Checklist Before Starting

  • [ ] Search for similar PRs. Paste at least one query link here: ...
  • [ ] Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

[!IMPORTANT] Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

kunling-anyscale avatar Oct 04 '25 00:10 kunling-anyscale

@kunling-anyscale Please format code with: https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting

wuxibin89 avatar Oct 09 '25 03:10 wuxibin89

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Kunling Geng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Nov 10 '25 02:11 CLAassistant