volcano icon indicating copy to clipboard operation
volcano copied to clipboard

Support suspend like a batch job

Open GhangZh opened this issue 2 years ago • 9 comments

What would you like to be added:

Do we have plans to add a suspend field like the k8s native batch job?

GhangZh avatar Apr 13 '23 06:04 GhangZh

Thank you for participating in the community exchange, can you describe your application scenario in detail, and what else do you hope the community will do?

wangyang0616 avatar Apr 14 '23 05:04 wangyang0616

Currently there is no such field, but I think we need one.

hwdef avatar Apr 22 '23 16:04 hwdef

/assign

sbdtu5498 avatar May 13 '23 21:05 sbdtu5498

This feature is already present and can be accessed via the CLI command "vsuspend", so I think it would be safe to close this issue.

sbdtu5498 avatar May 13 '23 22:05 sbdtu5498

/unassign

sbdtu5498 avatar May 13 '23 22:05 sbdtu5498

Hello 👋 Looks like there was no activity on this issue for last 90 days. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity for 60 days, this issue will be closed (we can always reopen an issue if we need!).

stale[bot] avatar Sep 17 '23 21:09 stale[bot]

This feature is already present and can be accessed via the CLI command "vsuspend", so I think it would be safe to close this issue.

The implementation you are referring to is to change the job from a pending/running state to Aborting/Aborted so that the volcanojob will be deleted,I would expect it to be suspended after suspend and the volcanojob not be deleted. Like batch/job suspend.

GhangZh avatar Oct 31 '23 08:10 GhangZh

Hi @GhangZh seems the job will not be deleted, see https://github.com/volcano-sh/volcano/blob/a566d48f54b7f31513efa51045a6492a946430fc/pkg/controllers/job/job_controller_actions.go#L428,

cc @william-wang for confirmation.

kerthcet avatar Jan 31 '24 06:01 kerthcet

That means volcano supports the Suspend/Unsuspend semantic.

kerthcet avatar Jan 31 '24 06:01 kerthcet