load-balancer-and-ingress-services-for-kubernetes icon indicating copy to clipboard operation
load-balancer-and-ingress-services-for-kubernetes copied to clipboard

Add dual-stack support for NPL and NodePort

Open Qwiko opened this issue 1 year ago • 4 comments

My attempt to resolve #1535. Would like some input from the maintainers if this approach is a good one. In PopulateServersForNPL there is some duplicate code now that could be tweaked further. Also: I have not looked over PopulateServers in this PR but would like some input if this also needs to be tweaked to fully support dual-stack support.

Qwiko avatar Sep 11 '24 14:09 Qwiko

@Qwiko, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

vmwclabot avatar Sep 11 '24 14:09 vmwclabot

No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR.

Dhivyaaj avatar Sep 11 '24 14:09 Dhivyaaj

Can one of the admins verify this patch?

akshayhavile avatar Sep 11 '24 14:09 akshayhavile

@Qwiko, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

vmwclabot avatar Sep 11 '24 14:09 vmwclabot

@Qwiko, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

test reject

vmwclabot avatar Oct 14 '24 08:10 vmwclabot

@Qwiko, VMware has approved your signed contributor license agreement.

vmwclabot avatar Oct 16 '24 00:10 vmwclabot