load-balancer-and-ingress-services-for-kubernetes icon indicating copy to clipboard operation
load-balancer-and-ingress-services-for-kubernetes copied to clipboard

Published 20 hours ago • verified publisher icon vmware

Support reading credentials from env

Open k0da opened this issue 2 years ago • 13 comments

If GitOps setups secrets are not commited to the helm values, but rather delivered aside by for example ExternalSecrets. Hence we need an ability to inject CTRL_USERNAME and CTRL_PASSWORD from externally managed secret.

This commit adds CTLR_USERNAME and CTRL_PASSWORD override if environment variable is set.

Additionally helm chart has been extended to allow specifying extraEnv to perform mapping of secret name and key as environment variable

k0da avatar Oct 16 '23 10:10 k0da

No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR.

Dhivyaaj avatar Oct 16 '23 10:10 Dhivyaaj

@k0da, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

vmwclabot avatar Oct 16 '23 10:10 vmwclabot

Can one of the admins verify this patch?

akshayhavile avatar Oct 16 '23 10:10 akshayhavile

@k0da, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

vmwclabot avatar Oct 16 '23 10:10 vmwclabot

also fixes: https://github.com/vmware/load-balancer-and-ingress-services-for-kubernetes/issues/1145

k0da avatar Oct 16 '23 12:10 k0da

@k0da, VMware has approved your signed contributor license agreement.

vmwclabot avatar Oct 17 '23 08:10 vmwclabot

skip jira-id-check

k0da avatar Oct 17 '23 13:10 k0da

Could somebody please give a review on this?

k0da avatar Oct 23 '23 07:10 k0da

@k0da We will check it. Thanks.

akshayhavile avatar Oct 23 '23 08:10 akshayhavile

@k0da : Already raised PR: https://github.com/vmware/load-balancer-and-ingress-services-for-kubernetes/pull/732/files addresses the issue of using existing secrets.

akshayhavile avatar Oct 23 '23 09:10 akshayhavile

@akshayhavile I'm fine with either approach. It just prevents me to roll AKO across 100+ clusters

k0da avatar Oct 23 '23 09:10 k0da

@k0da We will take care of this in upcoming release

akshayhavile avatar Nov 03 '23 05:11 akshayhavile

also fixes https://github.com/vmware/load-balancer-and-ingress-services-for-kubernetes/issues/1367

lknite avatar Jan 25 '24 18:01 lknite