tanzu-framework icon indicating copy to clipboard operation
tanzu-framework copied to clipboard

Added several logging specificity breadcrumbs for the overall Tanzu C…

Open jayunit100 opened this issue 2 years ago • 5 comments
trafficstars

Redo of #4266, hopefully will pass linting this time. No idea what was wrong w/ the last PR.

jayunit100 avatar Feb 03 '23 20:02 jayunit100

Cluster Generation A/B Results: https://storage.googleapis.com/tkg-clustergen/4328/20230203204956/clustergen.diff.txt Author/reviewers: Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions[bot] avatar Feb 03 '23 20:02 github-actions[bot]

Cluster Generation A/B Results: https://storage.googleapis.com/tkg-clustergen/4328/20230204151713/clustergen.diff.txt Author/reviewers: Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions[bot] avatar Feb 04 '23 15:02 github-actions[bot]

Cluster Generation A/B Results: https://storage.googleapis.com/tkg-clustergen/4328/20230206202633/clustergen.diff.txt Author/reviewers: Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions[bot] avatar Feb 06 '23 20:02 github-actions[bot]

Codecov Report

Merging #4328 (0ed7d4a) into main (6cdbd30) will decrease coverage by 0.92%. The diff coverage is 4.54%.

@@            Coverage Diff             @@
##             main    #4328      +/-   ##
==========================================
- Coverage   49.55%   48.63%   -0.92%     
==========================================
  Files         452      482      +30     
  Lines       44849    46984    +2135     
==========================================
+ Hits        22225    22851     +626     
- Misses      20513    21969    +1456     
- Partials     2111     2164      +53     
Impacted Files Coverage Δ
tkg/client/client.go 90.62% <ø> (ø)
tkg/client/upgrade_region.go 28.37% <0.00%> (ø)
tkg/clusterclient/clusterclient.go 49.14% <ø> (ø)
tkg/tkgctl/helpers.go 62.52% <0.00%> (-0.45%) :arrow_down:
tkg/client/cluster.go 32.77% <5.55%> (-0.52%) :arrow_down:
addons/controllers/machine_controller.go 65.65% <0.00%> (-3.04%) :arrow_down:
tkg/client/upgrade_cluster_clusterclass.go 100.00% <0.00%> (ø)
cmd/cli/plugin/cluster/available_upgrade.go 16.32% <0.00%> (ø)
.../cli/plugin/cluster/get_machinehealthcheck_node.go 9.30% <0.00%> (ø)
cmd/cli/plugin/cluster/main.go 0.00% <0.00%> (ø)
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Feb 06 '23 21:02 codecov[bot]

re running tests, right now

  • plugin tests
  • tkg integration tests are failing...

jayunit100 avatar Feb 14 '23 21:02 jayunit100