ksar icon indicating copy to clipboard operation
ksar copied to clipboard

Published 20 hours ago • verified publisher icon vlsi

NaturalComparator adjust Regex WORD_PATTERN, remove isDigit

Open Pitterling opened this issue 3 years ago • 4 comments

adjust Regex - find several chars at once like for digits remove variable isDigit copyright 2022

Pitterling avatar Jan 05 '22 10:01 Pitterling

Could you add tests to cover the change? What is the reason?

vlsi avatar Jan 05 '22 10:01 vlsi

no futher tests required - but all test succeed we typically compare anything like dev8-xxx to dev8-yyy or ethX to ethY .. current implementation would compare char by char e,t,h .. this here will directly compare eth and eth

Pitterling avatar Jan 05 '22 11:01 Pitterling

still any objections ?

Pitterling avatar Jan 15 '22 13:01 Pitterling

Will review shortly

vlsi avatar Jan 15 '22 14:01 vlsi