Vladimir Sitnikov

Results 1003 comments of Vladimir Sitnikov

What do you think of creating a property/function on Expect instead of adding parameters all over the place?

I guess this issue duplicates https://github.com/robstoll/atrium/issues/724

> I think we still need an option on the expectation function level because otherwise you will incorporate a side effect in your expectation function which might change the behaviour...

>I think it is enough, if one can define this at the RootExpect Feature-level things (e.g. nested expect that changes subject) are not much different from RootExpect.

> For the same reason, I am hesitant to add an option for an expectation group, something like: ```kotlin fun Expect.between(t1: T, t2: T) = .and { report = {...

I would prefer a structured way. In other words, I think I would always prefer groups when more than one thing is verified. For instance: ```kotlin expect(x) { showSummary() //...

Even though Spring Boot prints the requests, they do not answer **why** certain value was expected. Here's an example: https://github.com/robstoll/atrium/blob/b00b0cb34d66c0d821487ae5e9e57795c41ff491/atrium-core/src/jsTest/kotlin/ch/tutteli/atrium/reporting/erroradjusters/AdjustStackTest.kt#L45-L53 It has two assertions: 1. `it notToContain o entry {...

> however, it might be better to have a way to describe why you expect certain things. >I guess you missed this comment https://github.com/robstoll/atrium/issues/1332#issuecomment-1433769882 I put wrong words. I should...

> because you just repeat what you expect Even though I repeat, it is way easier to write than figuring out the APIs with "feature extraction". The mental task is...

> the only thing missing is that 19 corresponded to pse_units_total check `overall_info action's finished_when should be the same as session's last_updated` Those values come from different entities, so a...