vllm icon indicating copy to clipboard operation
vllm copied to clipboard

WIP [P/D] Use ThreadPoolExecutor to do handshake for each P-D pair

Open lk-chen opened this issue 5 months ago • 2 comments

Essential Elements of an Effective PR Description Checklist

  • [x] The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • [x] The test plan, such as providing test command.
  • [ ] The test results, such as pasting the results comparison before and after, or e2e results
  • [ ] (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Split from #19447, this PR keeps using zmq for nixl metadata transfer, but uses ThreadPoolExecutor to do _nixl_handshake in background.

closes #19777

Test Plan

Unit test WIP

Test Result

(Optional) Documentation Update

lk-chen avatar Jun 19 '25 00:06 lk-chen

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

github-actions[bot] avatar Jun 19 '25 00:06 github-actions[bot]

This pull request has merge conflicts that must be resolved before it can be merged. Please rebase the PR, @lk-chen.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

mergify[bot] avatar Jun 19 '25 04:06 mergify[bot]

close in favor of #19836

lk-chen avatar Jun 19 '25 17:06 lk-chen