vllm icon indicating copy to clipboard operation
vllm copied to clipboard

[Lora][Frontend]Add default local directory LoRA resolver plugin.

Open jberkhahn opened this issue 7 months ago • 2 comments

This is my conversion of the implementation of #14634 into a plugin for the framework added in #10546.

This plugin with be "installed" by default, but LoRA resolvers will only run if VLLM_ALLOW_RUNTIME_LORA_UPDATING is set to True, and then on top of that this resolver with only register itself if VLLM_PLUGIN_LORA_CACHE_DIR is set to a local directory that exists.

FIX #12174

jberkhahn avatar Apr 18 '25 16:04 jberkhahn

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

github-actions[bot] avatar Apr 18 '25 16:04 github-actions[bot]

hmm, looks like the test_completion unit test isn't working because the plugin isn't getting picked up :/

jberkhahn avatar Apr 30 '25 23:04 jberkhahn

You can try sync the main branch to avoid the CI failure

jeejeelee avatar May 08 '25 01:05 jeejeelee

@jeejeelee rebased it again, that doesn't seem to have fixed it?

jberkhahn avatar May 08 '25 20:05 jberkhahn

It doesn't matter, if these failures are not related to this PR, we can consider force merging it.

jeejeelee avatar May 09 '25 01:05 jeejeelee