vllm icon indicating copy to clipboard operation
vllm copied to clipboard

Published 20 hours ago • verified publisher icon vllm-project

[RFC]: Drop support for prompt adapter

Open WoosukKwon opened this issue 9 months ago • 8 comments

Motivation.

For code cleanup, we plan to drop the support for prompt adapter. Please let us know if you are using this feature.

Proposed Change.

Dropping the prompt adapter and relevant code.

Feedback Period.

2 weeks.

CC List.

No response

Any Other Things.

No response

Before submitting a new issue...

  • [x] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

WoosukKwon avatar Feb 27 '25 17:02 WoosukKwon

+1

simon-mo avatar Feb 27 '25 18:02 simon-mo

+1 I don't see much usage about this feature.

youkaichao avatar Mar 06 '25 16:03 youkaichao

Is the proposal to remove it from V0 and V1? Or is this feature engine version agnostic?

hmellor avatar Mar 06 '25 16:03 hmellor

IBM uses this feature but I don't think plans to long term. Can we keep the existing V0 implementation for the time being and just declare that it is deprecated and won't be supported in V1?

njhill avatar Mar 06 '25 18:03 njhill

Happy to do it with @b8zhong

vincent-4 avatar Mar 06 '25 23:03 vincent-4

+1

jeejeelee avatar Mar 07 '25 01:03 jeejeelee

IBM uses this feature but I don't think plans to long term. Can we keep the existing V0 implementation for the time being and just declare that it is deprecated and won't be supported in V1?

this is also doable. since we will focus on v1, we should only do bugfix on v0. removing code will potentially introduce new bugs, which can be undesired.

youkaichao avatar Mar 07 '25 04:03 youkaichao

@vincent-4 we should probably leave the references in so that users switching get told that it's not supported. This is probably a better experience than it not working when switching to V1 and having to check GitHub issues to find out.

hmellor avatar Mar 07 '25 08:03 hmellor

This issue has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this issue should remain open. Thank you!

github-actions[bot] avatar Jun 06 '25 02:06 github-actions[bot]

This issue has been automatically closed due to inactivity. Please feel free to reopen if you feel it is still relevant. Thank you!

github-actions[bot] avatar Jul 07 '25 02:07 github-actions[bot]

Letting the bot close this as not planned is misleading. We do plan to drop support in V1.

hmellor avatar Jul 07 '25 10:07 hmellor