vllm icon indicating copy to clipboard operation
vllm copied to clipboard

Make log statistics interval configurable

Open Sakalya opened this issue 9 months ago • 2 comments

This PR aims to make "interval" for logging stats configurable.

Sakalya avatar Feb 16 '25 11:02 Sakalya

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

github-actions[bot] avatar Feb 16 '25 11:02 github-actions[bot]

@markmc Can you help to review this please ?

Sakalya avatar Feb 16 '25 13:02 Sakalya

Thanks for your PR! I don't think you need to ping the whole squad of maintainers to review this though 🤔

PR probably belongs to the [Misc] category. Also, try to address the DCO check to make it ready for merging first.

NickLucche avatar Feb 19 '25 10:02 NickLucche

Thanks @NickLucche. I have addressed DCO failures. Could you please help to review the PR ?

Sakalya avatar Feb 19 '25 13:02 Sakalya

This pull request has merge conflicts that must be resolved before it can be merged. Please rebase the PR, @Sakalya.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

mergify[bot] avatar May 18 '25 14:05 mergify[bot]

Missed this one, sorry. The PR could use a rebase if you're still interested.

NickLucche avatar May 21 '25 08:05 NickLucche