vllm
vllm copied to clipboard
[Misc] Qwen2.5 VL support LoRA
👋 Hi! Thank you for contributing to the vLLM project.
💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.
Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.
To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.
🚀
Is there a HF repo that can be used to test this?
Is there a HF repo that can be used to test this?
Not yet, if needed, I can train and add tests
@imkero @wulipc do you have any LoRA-tuned models that can be used? cc @ywang96
@imkero @wulipc do you have any LoRA-tuned models that can be used? cc @ywang96
Sorry I don't have one currently
@imkero @wulipc do you have any LoRA-tuned models that can be used? cc @ywang96
Sorry I don't have one currently
It would be great if we can test LoRA but I'm also somewhat okay with shipping this PR as is since LoRA support itself is model agnostic IMO.
@imkero @wulipc do you have any LoRA-tuned models that can be used? cc @ywang96
Sorry I don't have one currently
It would be great if we can test LoRA but I'm also somewhat okay with shipping this PR as is since LoRA support itself is model agnostic IMO.
I am glad to add this test ,and will handling asap
@DarkLight1337 @ywang96 I have added the LoRA test
@DarkLight1337 It looks like we need force merge