vllm icon indicating copy to clipboard operation
vllm copied to clipboard

[Misc] Qwen2.5 VL support LoRA

Open jeejeelee opened this issue 9 months ago • 7 comments

jeejeelee avatar Feb 14 '25 06:02 jeejeelee

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

github-actions[bot] avatar Feb 14 '25 06:02 github-actions[bot]

Is there a HF repo that can be used to test this?

DarkLight1337 avatar Feb 14 '25 06:02 DarkLight1337

Is there a HF repo that can be used to test this?

Not yet, if needed, I can train and add tests

jeejeelee avatar Feb 14 '25 06:02 jeejeelee

@imkero @wulipc do you have any LoRA-tuned models that can be used? cc @ywang96

DarkLight1337 avatar Feb 14 '25 07:02 DarkLight1337

@imkero @wulipc do you have any LoRA-tuned models that can be used? cc @ywang96

Sorry I don't have one currently

imkero avatar Feb 14 '25 07:02 imkero

@imkero @wulipc do you have any LoRA-tuned models that can be used? cc @ywang96

Sorry I don't have one currently

It would be great if we can test LoRA but I'm also somewhat okay with shipping this PR as is since LoRA support itself is model agnostic IMO.

ywang96 avatar Feb 14 '25 07:02 ywang96

@imkero @wulipc do you have any LoRA-tuned models that can be used? cc @ywang96

Sorry I don't have one currently

It would be great if we can test LoRA but I'm also somewhat okay with shipping this PR as is since LoRA support itself is model agnostic IMO.

I am glad to add this test ,and will handling asap

jeejeelee avatar Feb 14 '25 11:02 jeejeelee

@DarkLight1337 @ywang96 I have added the LoRA test

jeejeelee avatar Feb 19 '25 11:02 jeejeelee

@DarkLight1337 It looks like we need force merge

jeejeelee avatar Feb 20 '25 01:02 jeejeelee