vllm icon indicating copy to clipboard operation
vllm copied to clipboard

Move requirements into their own directory

Open hmellor opened this issue 10 months ago • 5 comments

Moves requirements-x.txt to requirements/x.txt and updates all references to requirements files.

hmellor avatar Jan 29 '25 11:01 hmellor

👋 Hi! Thank you for contributing to the vLLM project. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

github-actions[bot] avatar Jan 29 '25 11:01 github-actions[bot]

This pull request has merge conflicts that must be resolved before it can be merged. Please rebase the PR, @hmellor.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

mergify[bot] avatar Jan 29 '25 11:01 mergify[bot]

requirements-docs.txt currently lives inside docs, so it's not cluttering the root directory like the others. Would you still like requirements-docs.txt to live with the rest?

hmellor avatar Mar 07 '25 10:03 hmellor

Would you still like requirements-docs.txt to live with the rest?

Yeah, that's what I mean.

DarkLight1337 avatar Mar 07 '25 10:03 DarkLight1337

Done

hmellor avatar Mar 07 '25 11:03 hmellor

Thanks for doing this. I'm super excited about this cleanup.

WoosukKwon avatar Mar 08 '25 02:03 WoosukKwon

Good catch @simon-mo, fixed!

hmellor avatar Mar 08 '25 07:03 hmellor