angular-datepicker
angular-datepicker copied to clipboard
feat(dateRangePicker): Adding DateRangePicker feature
Hi! I've started to work on date range picker feature https://github.com/vlio20/angular-datepicker/issues/54. I'm a bit confused, I hope I'm doing correct. Features to be added:
- Hover indication of the range.
- Max & MIn range validations.
- Preview format.
- inline mode.
- Multiple ranges (advanced feature - not mandatory).
I will work tomorrow on the features that you wrote. I did the changes that you mentioned in the review. Thank you for your review, this is really important for me! Could you share a formatting config file (like .prettierrc)?
@mustafapsd I don't have one. I am ok with adding a prettier but it should be on a different PR.
@mustafapsd it's very hard to follow the changes because of the linters. Can you please undo them so I can review the actual code that is related to the range feature?
Few more notes:
- Maybe it is better to have a dedicated component for the range picker?
- Other calendars should also be supported - dateTime/month.
We would also need to add e2e tests.
Sorry for linters, writing without formatting is really hard :S
Actually I think the same thing. This will be getting bigger day to day, so will be hard to change.
I never saw time or month pickers in date range pickers. Is it really necessary?
Yes I'll add tests.
It is not mandatory but should somehow be reflected there.
For liniting, I suggest that you create a separate PR with the your prettier config file then create PR for the rangepicker. WDYT?
I removed linting changes for now. Is this logic true for date range pickers? If I'm doing it correctly then I'll create a new component for the range picker.
I will try to pull your fork and play with it and give you my feedback
Thank you!