angular-datepicker icon indicating copy to clipboard operation
angular-datepicker copied to clipboard

[Feature Request] making double arrows available in day view

Open albancho opened this issue 5 years ago • 2 comments

Hello there,

This PR made a double arrow available in the month view, to navigate multiple years back/forward, with showMultipleYearsNavigation and multipleYearsNavigateBy parameters.

What about being able to navigate by year in the day picker ?

The simple arrow would do "+/- 1 month", and double arrow would do "+/- 1 year".

It seems possible to reuse what has been done with showMultipleYearsNavigation, using multipleYearsNavigateBy = 1. So all we would have to do, is add the code which is in the month picker to the day picker.

To be closer to the month behavior, multipleYearsNavigateBy could define a number of month, instead of a number of year. So setting a value of "12" would do "+/- 1 year", but the parameter should then change its name...

In the code, the button is called "Left/rightSecondaryButton", so the parameters could be showSecondaryNavigation, and secondaryNavigationStep ?

I would love to make a PR about this, if you could tell me which branch to base onto.

albancho avatar Apr 28 '20 12:04 albancho

This is a great idea. Please PR it to the next branch. Don't forget to add unit + e2e tests and documentation.

I am here for any question.

vlio20 avatar Apr 28 '20 17:04 vlio20

Nice, @vlio20 I made PR #502.
Strange thing is that the fork does not include the next branch, but ok in PR 👍

albancho avatar Apr 29 '20 14:04 albancho