Vladimir Kotal

Results 485 comments of Vladimir Kotal

Feel free to take it !

The goal is to convert `groups` in `Configuration` to use `HashMap`. See https://github.com/oracle/opengrok/blob/5f88acb4406c8e728ddf626ec6d37eb8b5d81e34/opengrok-indexer/src/main/java/org/opengrok/indexer/configuration/Configuration.java#L151-L152

> so basically I have to convert the Set into a hash map? @vladak Yep !

> @vladak I should use Map or Map? > Please help the latter. It should mimic what is done for projects.

No, you need to convert the code so that it uses the `HashMap` natively, not just a conversion from the existing set.

Yep, begin with: ```java private Map projects; // project name -> Project private Map groups; // group name -> Group ``` and adapt the rest of the code.

You need to see how exactly is the `group` member used and adapt the rest of the code. This is definitely not a one liner change. Read the code extensively...

Seems like we will have races of who will fix this first :-) Feel free to submit a PR. As for the testing, you can totally do it yourself. Just...

Definitely the setters/getters need to adapt. And any other code that uses the value returned from the getter. Just keep bubbling/propagating this.

The status says open and there is PR #3873 in progress. Looks like there is a bit of contention for this one :-) There are lots of other, potentially more...